echauchot commented on code in PR #3: URL: https://github.com/apache/flink-connector-cassandra/pull/3#discussion_r1138350686
########## flink-connector-cassandra/src/test/java/org/apache/flink/connector/cassandra/source/CassandraSourceITCase.java: ########## @@ -0,0 +1,239 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.connector.cassandra.source; + +import org.apache.flink.connector.cassandra.source.split.CassandraSplit; +import org.apache.flink.connector.cassandra.source.split.SplitsGenerator; +import org.apache.flink.connector.testframe.environment.ClusterControllable; +import org.apache.flink.connector.testframe.environment.MiniClusterTestEnvironment; +import org.apache.flink.connector.testframe.environment.TestEnvironment; +import org.apache.flink.connector.testframe.external.source.DataStreamSourceExternalContext; +import org.apache.flink.connector.testframe.junit.annotations.TestContext; +import org.apache.flink.connector.testframe.junit.annotations.TestEnv; +import org.apache.flink.connector.testframe.junit.annotations.TestExternalSystem; +import org.apache.flink.connector.testframe.junit.annotations.TestSemantics; +import org.apache.flink.connector.testframe.testsuites.SourceTestSuiteBase; +import org.apache.flink.connector.testframe.utils.CollectIteratorAssertions; +import org.apache.flink.connectors.cassandra.utils.Pojo; +import org.apache.flink.streaming.api.CheckpointingMode; +import org.apache.flink.util.CloseableIterator; + +import org.junit.jupiter.api.Disabled; +import org.junit.jupiter.api.DisplayName; +import org.junit.jupiter.api.TestTemplate; + +import java.util.List; + +import static java.util.concurrent.CompletableFuture.runAsync; +import static org.apache.flink.connector.cassandra.source.CassandraTestContext.CassandraTestContextFactory; +import static org.apache.flink.connector.cassandra.source.split.SplitsGenerator.CassandraPartitioner.MURMUR3PARTITIONER; +import static org.apache.flink.connector.cassandra.source.split.SplitsGenerator.CassandraPartitioner.RANDOMPARTITIONER; +import static org.apache.flink.connector.testframe.utils.ConnectorTestConstants.DEFAULT_COLLECT_DATA_TIMEOUT; +import static org.assertj.core.api.Assertions.assertThat; + +/** Test for the Cassandra source. */ +class CassandraSourceITCase extends SourceTestSuiteBase<Pojo> { + + @TestEnv MiniClusterTestEnvironment flinkTestEnvironment = new MiniClusterTestEnvironment(); + + @TestExternalSystem + CassandraTestEnvironment cassandraTestEnvironment = new CassandraTestEnvironment(); + + @TestSemantics + CheckpointingMode[] semantics = new CheckpointingMode[] {CheckpointingMode.EXACTLY_ONCE}; + + @TestContext + CassandraTestContextFactory contextFactory = + new CassandraTestContextFactory(cassandraTestEnvironment); + + @TestTemplate + @DisplayName("Test basic splitting with MURMUR3PARTITIONER (default Cassandra partitioner)") + public void testGenerateSplitsMurMur3Partitioner( + TestEnvironment testEnv, + DataStreamSourceExternalContext<Pojo> externalContext, + CheckpointingMode semantic) { + final int parallelism = 2; + SplitsGenerator generator = + new SplitsGenerator( + MURMUR3PARTITIONER, + cassandraTestEnvironment.getSession(), + CassandraTestEnvironment.KEYSPACE, + CassandraTestEnvironment.SPLITS_TABLE, + parallelism, + null); + List<CassandraSplit> splits = generator.generateSplits(); + + // no maxSplitMemorySize specified falling back number of splits = parallelism + assertThat(splits.size()).isEqualTo(parallelism); + assertThat(splits.get(0).splitId()).isEqualTo("(-9223372036854775808,0)"); + assertThat(splits.get(1).splitId()).isEqualTo("(0,9223372036854775807)"); + } + + @TestTemplate + @DisplayName("Test basic splitting with RANDOMPARTITIONER") + public void testGenerateSplitsRandomPartitioner( + TestEnvironment testEnv, + DataStreamSourceExternalContext<Pojo> externalContext, + CheckpointingMode semantic) { + final int parallelism = 2; + final SplitsGenerator generator = + new SplitsGenerator( + RANDOMPARTITIONER, + cassandraTestEnvironment.getSession(), + CassandraTestEnvironment.KEYSPACE, + CassandraTestEnvironment.SPLITS_TABLE, + parallelism, + null); + List<CassandraSplit> splits = generator.generateSplits(); + + // no maxSplitMemorySize specified falling back number of splits = parallelism + assertThat(splits.size()).isEqualTo(parallelism); + assertThat(splits.get(0).splitId()).isEqualTo("(0,85070591730234615865843651857942052864)"); + assertThat(splits.get(1).splitId()) + .isEqualTo( + "(85070591730234615865843651857942052864,170141183460469231731687303715884105727)"); + } + + @TestTemplate + @DisplayName("Test splitting with a correct split size set") + public void testGenerateSplitsWithCorrectSize( + TestEnvironment testEnv, + DataStreamSourceExternalContext<Pojo> externalContext, + CheckpointingMode semantic) + throws Exception { + final int parallelism = 2; + SplitsGenerator generator = + new SplitsGenerator( + MURMUR3PARTITIONER, + cassandraTestEnvironment.getSession(), + CassandraTestEnvironment.KEYSPACE, + CassandraTestEnvironment.SPLITS_TABLE, + parallelism, + 10000L); + assertThat(generator.estimateTableSize()).isEqualTo(35840L); + List<CassandraSplit> splits = generator.generateSplits(); + // nb splits = tableSize / maxSplitMemorySize + assertThat(splits.size()).isEqualTo(3); + } + + @TestTemplate + @DisplayName("Test splitting with a too big split size set") + public void testGenerateSplitsWithTooBigSize( + TestEnvironment testEnv, + DataStreamSourceExternalContext<Pojo> externalContext, + CheckpointingMode semantic) + throws Exception { + final int parallelism = 20; + SplitsGenerator generator = + new SplitsGenerator( + MURMUR3PARTITIONER, + cassandraTestEnvironment.getSession(), + CassandraTestEnvironment.KEYSPACE, + CassandraTestEnvironment.SPLITS_TABLE, + parallelism, + 100_000_000L); + assertThat(generator.estimateTableSize()).isEqualTo(35840L); + List<CassandraSplit> splits = generator.generateSplits(); + // tableSize / maxSplitMemorySize is too little compared to parallelism falling back to + // number of splits = parallelism + assertThat(splits.size()).isEqualTo(parallelism); + } + + @TestTemplate + @DisplayName("Test splitting with a too small split size set") + public void testGenerateSplitsWithTooSmallSize( + TestEnvironment testEnv, + DataStreamSourceExternalContext<Pojo> externalContext, + CheckpointingMode semantic) + throws Exception { + final int parallelism = 2; + SplitsGenerator generator = + new SplitsGenerator( + MURMUR3PARTITIONER, + cassandraTestEnvironment.getSession(), + CassandraTestEnvironment.KEYSPACE, + CassandraTestEnvironment.SPLITS_TABLE, + parallelism, + 1L); + assertThat(generator.estimateTableSize()).isEqualTo(35840L); + List<CassandraSplit> splits = generator.generateSplits(); + + // tableSize / maxSplitMemorySize is too big compared to parallelism falling back to + // number of splits = parallelism + assertThat(splits.size()).isEqualTo(parallelism); + } + + // overridden to use unordered checks + @Override + protected void checkResultWithSemantic( + CloseableIterator<Pojo> resultIterator, + List<List<Pojo>> testData, + CheckpointingMode semantic, + Integer limit) { + if (limit != null) { + Runnable runnable = + () -> + CollectIteratorAssertions.assertUnordered(resultIterator) + .withNumRecordsLimit(limit) + .matchesRecordsFromSource(testData, semantic); + + assertThat(runAsync(runnable)).succeedsWithin(DEFAULT_COLLECT_DATA_TIMEOUT); Review Comment: No, I find it strange as well as we assert asynchronously on a limited number of records and synchronously on a unlimited (finite but potentially big) number of records. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
