xuzhiwen1255 commented on code in PR #22208:
URL: https://github.com/apache/flink/pull/22208#discussion_r1141287207
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/operations/converters/SqlNodeConverters.java:
##########
@@ -37,9 +40,9 @@ public class SqlNodeConverters {
static {
// register all the converters here
register(new SqlCreateCatalogConverter());
- register(new SqlCreateTableAsConverter());
- register(new SqlCreateTableLikeConverter());
- register(new SqlCreateTableConverter());
+ register(new SqlCreateTableConverter(),
TypeInformation.of(SqlCreateTable.class));
+ register(new SqlCreateTableConverter(),
TypeInformation.of(SqlCreateTableAs.class));
+ register(new SqlCreateTableConverter(),
TypeInformation.of(SqlCreateTableLike.class));
Review Comment:
Or create separate SqlNodeConverter for SqlCreateTableAs and
SqlCreateTableLike.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
