[
https://issues.apache.org/jira/browse/FLINK-4563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15582287#comment-15582287
]
ASF GitHub Bot commented on FLINK-4563:
---------------------------------------
GitHub user ex00 opened a pull request:
https://github.com/apache/flink/pull/2650
[FLINK-4563] [metrics] scope caching not adjusted for multiple reporters
Hello.
It is implementation FLINK-4563.
In ``AbstractMetricGroup.java`` added characterFilter and
firstReporterIndex for cached scopeString
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ex00/flink FLINK-4563
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/2650.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2650
----
commit ad3034b4d9764426dd5f969b20c12aa3145cbf84
Author: Anton Mushin <[email protected]>
Date: 2016-10-17T13:23:01Z
[FLINK-4563] [metrics] scope caching not adjusted for multiple reporters
----
> [metrics] scope caching not adjusted for multiple reporters
> -----------------------------------------------------------
>
> Key: FLINK-4563
> URL: https://issues.apache.org/jira/browse/FLINK-4563
> Project: Flink
> Issue Type: Bug
> Components: Metrics
> Affects Versions: 1.1.0
> Reporter: Chesnay Schepler
> Assignee: Anton Mushin
>
> Every metric group contains a scope string, representing what entities
> (job/task/etc.) a given metric belongs to, which is calculated on demand.
> Before this string is cached a CharacterFilter is applied to it, which is
> provided by the callee, usually a reporter. This was done since different
> reporters have different requirements in regards to valid characters. The
> filtered string is cached so that we don't have to refilter the string every
> time.
> This all works fine with a single reporter; with multiple however it is
> completely broken as only the first filter is ever applied.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
