wuchong commented on code in PR #22213:
URL: https://github.com/apache/flink/pull/22213#discussion_r1141996394
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/operations/converters/SqlNodeConverters.java:
##########
@@ -46,19 +49,51 @@ public class SqlNodeConverters {
@SuppressWarnings({"unchecked", "rawtypes"})
public static Optional<Operation> convertSqlNode(
SqlNode validatedSqlNode, ConvertContext context) {
- SqlNodeConverter converter =
CONVERTERS.get(validatedSqlNode.getClass());
- if (converter != null) {
- return Optional.of(converter.convertSqlNode(validatedSqlNode,
context));
+ // match by class first
+ SqlNodeConverter classConverter =
CLASS_CONVERTERS.get(validatedSqlNode.getClass());
Review Comment:
Yes, that's right. Class converter should be a higher priority than SqlKind
converter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
