wuchong commented on code in PR #22213:
URL: https://github.com/apache/flink/pull/22213#discussion_r1142001985
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/operations/converters/SqlNodeConverter.java:
##########
@@ -37,6 +47,19 @@
*/
Operation convertSqlNode(S node, ConvertContext context);
+ /**
+ * Returns the {@link SqlKind SqlKinds} of {@link SqlNode SqlNodes} that
the {@link
+ * SqlNodeConverter} supports to convert.
+ *
+ * <p>If a {@link SqlNodeConverter} return s a non-empty SqlKinds, the
conversion framework
+ * prefer to match SqlKind of SqlNode instead of matching class of SqlNode.
Review Comment:
Good catch. I should remove the "prefer". Here should be "The conversion
framework will find the corresponding converter by matching the SqlKind of
SqlNode instead of the class of SqlNode".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
