echauchot commented on code in PR #3:
URL:
https://github.com/apache/flink-connector-cassandra/pull/3#discussion_r1143714659
##########
flink-connector-cassandra/src/main/java/org/apache/flink/connector/cassandra/source/enumerator/CassandraEnumeratorStateSerializer.java:
##########
@@ -86,10 +87,7 @@ public CassandraEnumeratorState deserialize(int version,
byte[] serialized) thro
for (int i = 0; i < splitsToReassignSize; i++) {
final int splitSize = objectInputStream.readInt();
final byte[] splitBytes = new byte[splitSize];
- if (objectInputStream.read(splitBytes) == -1) {
- throw new IOException(
- "EOF received while deserializing
CassandraEnumeratorState.splitsToReassign");
- }
+ IOUtils.readFully(objectInputStream, splitBytes, 0, splitSize);
Review Comment:
Yet another flink util that I did not know. Thanks
##########
flink-connector-cassandra/src/test/java/org/apache/flink/connector/cassandra/source/CassandraTestContext.java:
##########
@@ -88,7 +88,6 @@ public List<URL> getConnectorJarPaths() {
return new CassandraSource<>(
clusterBuilder,
- CassandraSource.MAX_SPLIT_MEMORY_SIZE_DEFAULT,
Review Comment:
:+1: forgot this cleaning
##########
flink-connector-cassandra/src/main/java/org/apache/flink/connector/cassandra/source/split/CassandraSplitSerializer.java:
##########
@@ -44,12 +45,8 @@ public int getVersion() {
@Override
public byte[] serialize(CassandraSplit cassandraSplit) throws IOException {
final DataOutputSerializer out = SERIALIZER_CACHE.get();
- final byte[] ringRangeStart =
cassandraSplit.getRingRangeStart().toByteArray();
Review Comment:
Ah yes, I did the change in the enumerator state serializer but forgot the
split serializer. Thanks
##########
flink-connector-cassandra/src/main/java/org/apache/flink/connector/cassandra/source/CassandraSource.java:
##########
@@ -99,35 +99,34 @@
private final String table;
private final MapperOptions mapperOptions;
- private final Long maxSplitMemorySize;
Review Comment:
I removed the `@Nullable`s but forgot these cleanings. Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
