Github user StephanEwen commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2652#discussion_r83800264
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/Task.java ---
    @@ -289,6 +294,10 @@ public Task(
                        ConfigConstants.TASK_CANCELLATION_INTERVAL_MILLIS,
                        
ConfigConstants.DEFAULT_TASK_CANCELLATION_INTERVAL_MILLIS);
     
    +           this.taskCancellationTimeout = jobConfiguration.getLong(
    --- End diff --
    
    I think the `jobConfiguration` is the wrong configuration here. It should 
probably be the TaskManager's configuration in the `taskManagerConfig`. Same 
probably holds for the cancellation interval above.
    
    Seems neither were ever tested?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to