Github user StephanEwen commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2652#discussion_r83800396
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/Task.java ---
    @@ -1183,47 +1220,48 @@ public String toString() {
         */
        private static class TaskCanceler implements Runnable {
     
    -           private final Logger logger;
                private final AbstractInvokable invokable;
                private final Thread executer;
    -           private final String taskName;
                private final long taskCancellationIntervalMillis;
                private final ResultPartition[] producedPartitions;
                private final SingleInputGate[] inputGates;
    +           private final CountDownLatch watchDogLatch;
     
                public TaskCanceler(
    -                           Logger logger,
    --- End diff --
    
    I think the logger was added to prevent that the compiler needs to inject 
static bridge methods to access it. Why not keep it?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to