luoyuxia commented on code in PR #22166:
URL: https://github.com/apache/flink/pull/22166#discussion_r1147328847


##########
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/delegation/DialectFactory.java:
##########
@@ -36,52 +34,22 @@
  * <p>The {@link #factoryIdentifier()} is identified by matching it against 
{@link
  * TableConfigOptions#TABLE_SQL_DIALECT}.
  */
-@Internal
+@PublicEvolving
 public interface DialectFactory extends Factory {
-
     /** Creates a new parser. */
     Parser create(Context context);
 
+    /** Create an extended operation executor. */
     default ExtendedOperationExecutor createExtendedOperationExecutor(Context 
context) {

Review Comment:
   Removing `ExtendedOperationExecutor` is good idea. It makes everything 
simple. I have updated it for removing and renming.
   Hope the internal `ExecutableOperation` interface won't change frequently
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to