ASF GitHub Bot commented on FLINK-4715:

Github user uce commented on the issue:

    We have the `TaskManagerProcessReapingTest` which tests that the 
TaskManager process properly exits when the TaskManager actor dies. In 
addition, there is `TaskManagerTest#testTerminationOnFatalError`, which tests 
that the `FatalError` message terminates the actor. 
    Do you think we are already covered by this? We can certainly add a process 
reaper test variant that sends a `FatalError` message instead of the 

> TaskManager should commit suicide after cancellation failure
> ------------------------------------------------------------
>                 Key: FLINK-4715
>                 URL: https://issues.apache.org/jira/browse/FLINK-4715
>             Project: Flink
>          Issue Type: Improvement
>          Components: TaskManager
>    Affects Versions: 1.2.0
>            Reporter: Till Rohrmann
>            Assignee: Ufuk Celebi
>             Fix For: 1.2.0
> In case of a failed cancellation, e.g. the task cannot be cancelled after a 
> given time, the {{TaskManager}} should kill itself. That way we guarantee 
> that there is no resource leak. 
> This behaviour acts as a safety-net against faulty user code.

This message was sent by Atlassian JIRA

Reply via email to