[
https://issues.apache.org/jira/browse/FLINK-31593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17706015#comment-17706015
]
Matthias Pohl commented on FLINK-31593:
---------------------------------------
Ok, I did a bit more digging. The savepoint phrase in the logs is generated,
because the checkpoint properties are set in
[CheckpointCoordinator.restoreSavepoint|https://github.com/apache/flink/blob/dca819556fb9b675852df99ada45e0f22262cb28/flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinator.java#L1828].
That means, even if we restore from a checkpoint, the logs will state
"Savepoint". ...at least if we rely on {{RestoreMode.LEGACY}} or
{{RestoreMode.NO_CLAIM}} (which seems to be [the
default|https://github.com/apache/flink/blob/c0936deaf99390fc727acc8633e3be22e62f4bf5/flink-runtime/src/main/java/org/apache/flink/runtime/jobgraph/RestoreMode.java#L57]
as far as I can see).
Therefore, the savepoint phrase shouldn't bother us in the logs.
> Update reference data for Migration Tests
> -----------------------------------------
>
> Key: FLINK-31593
> URL: https://issues.apache.org/jira/browse/FLINK-31593
> Project: Flink
> Issue Type: Sub-task
> Reporter: Matthias Pohl
> Assignee: Matthias Pohl
> Priority: Major
> Labels: pull-request-available
> Attachments:
> FLINK-31593.StatefulJobSavepointMigrationITCase.create_snapshot.log,
> FLINK-31593.StatefulJobSavepointMigrationITCase.verify_snapshot.log
>
>
> # Update {{CURRENT_VERSION in TypeSerializerUpgradeTestBase}} with the new
> version. This will likely fail some tests because snapshots are missing for
> that version. Generate them, for example in
> {{TypeSerializerUpgradeTestBase.}}
> # (major/minor only) Update migration tests in master to cover migration
> from new version: (search for usages of FlinkV{{{}ersion{}}})
> ** AbstractOperatorRestoreTestBase
> ** CEPMigrationTest
> ** BucketingSinkMigrationTest
> ** FlinkKafkaConsumerBaseMigrationTest
> ** ContinuousFileProcessingMigrationTest
> ** WindowOperatorMigrationTest
> ** StatefulJobSavepointMigrationITCase
> ** StatefulJobWBroadcastStateMigrationITCase
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
