[ 
https://issues.apache.org/jira/browse/FLINK-31593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17706679#comment-17706679
 ] 

Yanfei Lei commented on FLINK-31593:
------------------------------------

> But it still leaves question marks on why this issue didn't show up earlier.

I guess it is some corner case, 1.16 did not trigger this problem when creating 
checkpoint.

There are two possibilities for 
[lowestRetained|https://github.com/apache/flink/blob/master/flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/StandaloneCompletedCheckpointStore.java#L149-L184]
 = Long.Max:
 # The checkpoints deque is empty. Will manually triggered checkpoints be added 
to the deque?
 # The chk-3's props.discardOnJobCancelled is true. This contradicts 
CheckpointRetentionPolicy.RETAIN_ON_CANCELLATION, there may be some corner 
cases that have been ignored.

Have you tried re-creating the 1.17 checkpoint? Can the problem be reproduced?

> Update reference data for Migration Tests
> -----------------------------------------
>
>                 Key: FLINK-31593
>                 URL: https://issues.apache.org/jira/browse/FLINK-31593
>             Project: Flink
>          Issue Type: Sub-task
>            Reporter: Matthias Pohl
>            Assignee: Matthias Pohl
>            Priority: Major
>              Labels: pull-request-available
>         Attachments: 
> FLINK-31593.StatefulJobSavepointMigrationITCase.create_snapshot.log, 
> FLINK-31593.StatefulJobSavepointMigrationITCase.verify_snapshot.log
>
>
> # Update {{CURRENT_VERSION in TypeSerializerUpgradeTestBase}}  with the new 
> version. This will likely fail some tests because snapshots are missing for 
> that version. Generate them, for example in 
> {{TypeSerializerUpgradeTestBase.}} 
>  # (major/minor only) Update migration tests in master to cover migration 
> from new version: (search for usages of FlinkV{{{}ersion{}}})
>  ** AbstractOperatorRestoreTestBase
>  ** CEPMigrationTest
>  ** BucketingSinkMigrationTest
>  ** FlinkKafkaConsumerBaseMigrationTest
>  ** ContinuousFileProcessingMigrationTest
>  ** WindowOperatorMigrationTest
>  ** StatefulJobSavepointMigrationITCase
>  ** StatefulJobWBroadcastStateMigrationITCase



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to