RamanVerma commented on code in PR #15:
URL:
https://github.com/apache/flink-connector-kafka/pull/15#discussion_r1151154666
##########
flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/sink/FlinkKafkaInternalProducer.java:
##########
@@ -67,6 +72,14 @@ private static Properties withTransactionalId(
return props;
}
+ @Override
+ public Future<RecordMetadata> send(ProducerRecord<K, V> record, Callback
callback) {
+ if (inTransaction) {
+ hasRecordsInTransaction = true;
Review Comment:
Should this boolean be set in the callback, in the successful send scenario?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
