RamanVerma commented on code in PR #15:
URL:
https://github.com/apache/flink-connector-kafka/pull/15#discussion_r1151169873
##########
flink-connector-kafka/src/test/java/org/apache/flink/connector/kafka/sink/FlinkKafkaInternalProducerITCase.java:
##########
@@ -81,12 +80,58 @@ void testInitTransactionId() {
reuse.flush();
reuse.abortTransaction();
}
- assertNumTransactions(i);
+ assertNumTransactions(i, transactionIdPrefix);
assertThat(readRecords(topic).count()).isEqualTo(i / 2);
}
}
}
+ @Test
+ void testCommitResumedTransaction() {
+ final String topic = "test-commit-resumed-transaction";
+ final String transactionIdPrefix = "testCommitResumedTransaction-";
+ final String transactionalId = transactionIdPrefix + "id";
+
+ KafkaCommittable snapshottedCommittable;
+ try (FlinkKafkaInternalProducer<String, String> producer =
+ new FlinkKafkaInternalProducer<>(getProperties(),
transactionalId)) {
+ producer.initTransactions();
+ producer.beginTransaction();
+ producer.send(new ProducerRecord<>(topic, "test-value"));
+ producer.flush();
+ snapshottedCommittable = KafkaCommittable.of(producer, ignored ->
{});
+ }
+
+ try (FlinkKafkaInternalProducer<String, String> resumedProducer =
+ new FlinkKafkaInternalProducer<>(getProperties(),
transactionalId)) {
+ resumedProducer.resumeTransaction(
+ snapshottedCommittable.getProducerId(),
snapshottedCommittable.getEpoch());
+ resumedProducer.commitTransaction();
+ }
+
+ assertNumTransactions(1, transactionIdPrefix);
+ assertThat(readRecords(topic).count()).isEqualTo(1);
+ }
+
+ @Test
+ void testCommitResumedEmptyTransactionShouldFail() {
+ KafkaCommittable snapshottedCommittable;
+ try (FlinkKafkaInternalProducer<String, String> producer =
+ new FlinkKafkaInternalProducer<>(getProperties(), "dummy")) {
+ producer.initTransactions();
+ producer.beginTransaction();
+ snapshottedCommittable = KafkaCommittable.of(producer, ignored ->
{});
+ }
+
+ try (FlinkKafkaInternalProducer<String, String> resumedProducer =
+ new FlinkKafkaInternalProducer<>(getProperties(), "dummy")) {
+ resumedProducer.resumeTransaction(
+ snapshottedCommittable.getProducerId(),
snapshottedCommittable.getEpoch());
+
+ assertThatThrownBy(resumedProducer::commitTransaction);
Review Comment:
nit: Can we check the exception type also using
`isInstanceOf(<exception type>.class)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
