[ 
https://issues.apache.org/jira/browse/FLINK-3930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15588379#comment-15588379
 ] 

ASF GitHub Bot commented on FLINK-3930:
---------------------------------------

Github user mxm commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2425#discussion_r84028453
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/blob/BlobServerConnection.java
 ---
    @@ -463,6 +482,39 @@ private static String readKey(byte[] buf, InputStream 
inputStream) throws IOExce
                return new String(buf, 0, keyLength, BlobUtils.DEFAULT_CHARSET);
        }
     
    +
    +   /**
    +    * Reads secure cookie from the given input stream.
    +    *
    +    * @param inputStream
    +    *        the input stream to read the secure cookie from
    +    * @param keyLength
    +    *        buffer length to read
    +    * @return
    +    * @throws IOException
    +    *         thrown if an I/O error occurs while reading the secure 
cookie data from the input stream
    +    */
    +
    +   private void validateSecureCookie(InputStream inputStream, int 
keyLength) throws IOException {
    +
    +           if (keyLength > MAX_LENGTH_SECURE_COOKIE) {
    +                   throw new IOException("Unexpected secure cookie length 
" + keyLength);
    +           }
    +
    +           final byte[] buffer = new byte[BUFFER_SIZE];
    --- End diff --
    
    Does this oppose an upper limit on the cookie size?


> Implement Service-Level Authorization
> -------------------------------------
>
>                 Key: FLINK-3930
>                 URL: https://issues.apache.org/jira/browse/FLINK-3930
>             Project: Flink
>          Issue Type: New Feature
>          Components: Security
>            Reporter: Eron Wright 
>            Assignee: Vijay Srinivasaraghavan
>              Labels: security
>   Original Estimate: 672h
>  Remaining Estimate: 672h
>
> _This issue is part of a series of improvements detailed in the [Secure Data 
> Access|https://docs.google.com/document/d/1-GQB6uVOyoaXGwtqwqLV8BHDxWiMO2WnVzBoJ8oPaAs/edit?usp=sharing]
>  design doc._
> Service-level authorization is the initial authorization mechanism to ensure 
> clients (or servers) connecting to the Flink cluster are authorized to do so. 
>   The purpose is to prevent a cluster from being used by an unauthorized 
> user, whether to execute jobs, disrupt cluster functionality, or gain access 
> to secrets stored within the cluster.
> Implement service-level authorization as described in the design doc.
> - Introduce a shared secret cookie
> - Enable Akka security cookie
> - Implement data transfer authentication
> - Secure the web dashboard



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to