[
https://issues.apache.org/jira/browse/FLINK-3930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15588384#comment-15588384
]
ASF GitHub Bot commented on FLINK-3930:
---------------------------------------
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2425#discussion_r84030447
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/blob/BlobClient.java ---
@@ -88,6 +93,19 @@
*/
public BlobClient(InetSocketAddress serverAddress, Configuration
clientConfig) throws IOException {
+ this.socket = new Socket();
+
+ if(clientConfig != null) {
+ boolean securityEnabled =
clientConfig.getBoolean(ConfigConstants.SECURITY_ENABLED,
+
ConfigConstants.DEFAULT_SECURITY_ENABLED);
+
+ this.secureCookie =
clientConfig.getString(ConfigConstants.SECURITY_COOKIE, "");
+
+ if (securityEnabled && this.secureCookie == "") {
--- End diff --
Strings have to be compared with the `equals(String other)` method.
> Implement Service-Level Authorization
> -------------------------------------
>
> Key: FLINK-3930
> URL: https://issues.apache.org/jira/browse/FLINK-3930
> Project: Flink
> Issue Type: New Feature
> Components: Security
> Reporter: Eron Wright
> Assignee: Vijay Srinivasaraghavan
> Labels: security
> Original Estimate: 672h
> Remaining Estimate: 672h
>
> _This issue is part of a series of improvements detailed in the [Secure Data
> Access|https://docs.google.com/document/d/1-GQB6uVOyoaXGwtqwqLV8BHDxWiMO2WnVzBoJ8oPaAs/edit?usp=sharing]
> design doc._
> Service-level authorization is the initial authorization mechanism to ensure
> clients (or servers) connecting to the Flink cluster are authorized to do so.
> The purpose is to prevent a cluster from being used by an unauthorized
> user, whether to execute jobs, disrupt cluster functionality, or gain access
> to secrets stored within the cluster.
> Implement service-level authorization as described in the design doc.
> - Introduce a shared secret cookie
> - Enable Akka security cookie
> - Implement data transfer authentication
> - Secure the web dashboard
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
