zentol commented on code in PR #22350:
URL: https://github.com/apache/flink/pull/22350#discussion_r1158280277
##########
flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/RestHandlerConfiguration.java:
##########
@@ -96,13 +105,20 @@ public static RestHandlerConfiguration
fromConfiguration(Configuration configura
final boolean webSubmitEnabled =
configuration.getBoolean(WebOptions.SUBMIT_ENABLE);
final boolean webCancelEnabled =
configuration.getBoolean(WebOptions.CANCEL_ENABLE);
+ final boolean webRescaleSupported =
+ JobManagerOptions.SchedulerType.Adaptive.equals(
+ configuration.get(JobManagerOptions.SCHEDULER))
+ && configuration.get(JobManagerOptions.SCHEDULER_MODE)
== null;
+ final boolean webRescaleEnabled =
Review Comment:
`web.submit.enable` can also disable the jar handlers :sweat_smile:
I don't really like having 1 option for both the UI and REST API.
If we want to allow users to disable this, then I'd prefer a separate rest
option (that would then also potentially disable the UI option).
Not sure if we need that though in the first place.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
