zentol commented on code in PR #22350:
URL: https://github.com/apache/flink/pull/22350#discussion_r1163896475
##########
flink-runtime-web/web-dashboard/src/app/app.interceptor.ts:
##########
@@ -62,10 +65,8 @@ export class AppInterceptor implements HttpInterceptor {
ignoreErrorUrlEndsList.every(url => !res.url.endsWith(url)) &&
ignoreErrorMessage.every(message => errorMessage !== message)
) {
-
this.injector.get<StatusService>(StatusService).listOfErrorMessage.push(errorMessage);
- this.injector
- .get<NzNotificationService>(NzNotificationService)
- .info('Server Response Message:', errorMessage.replaceAll(' at ',
'\n at '), option);
+ this.statusService.listOfErrorMessage.push(errorMessage);
+ this.notificationService.info('Server Response Message:',
errorMessage.replaceAll(' at ', '\n at '), option);
Review Comment:
So was this just completely broken, or...?
(if so, something to backport to 1.17?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
