Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2425#discussion_r84034258
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/NettyMessage.java
---
@@ -131,6 +157,31 @@ protected void decode(ChannelHandlerContext ctx,
ByteBuf msg, List<Object> out)
throw new IllegalStateException("Network stream
corrupted: received incorrect magic number.");
}
+ //read cookie based on the cookie length passed
+ int cookieLength = msg.readInt();
+
+ LOG.debug("Cookie Length Read: {}, Source Cookie
Length: {}", cookieLength, secureCookie.length);
+
+ if(cookieLength != secureCookie.length) {
+ String message = "Cookie length does not match
with source cookie. Invalid secure cookie passed.";
+ LOG.error(message);
+ throw new IllegalStateException(message);
--- End diff --
Exceptions are always logged. No need to do the logging here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
