Github user mxm commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2425#discussion_r84029858
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/execution/librarycache/BlobLibraryCacheManager.java
 ---
    @@ -199,6 +199,11 @@ public int getBlobServerPort() {
                return blobService.getPort();
        }
     
    +   public String getSecureCookie() {
    +           return blobService.getSecureCookie() == null
    +                           ? "": blobService.getSecureCookie();
    --- End diff --
    
    I feel like this logic should be delegated to the blobService. Also, this 
might be clearer:
    ```java
    String secureCookie = blobService.getSecureCookie();
    return secureCookie != null ? secureCookie : ""
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to