echauchot commented on PR #21035: URL: https://github.com/apache/flink/pull/21035#issuecomment-1497504643
> @zentol what do you want that we do with this PR? Having no safe guard in the test waiting loop seems dangerous to me: during the implementation of a source, it could happen that the metrics counter is incorrect leading to infinite wait. IMHO I think we should merge this PR or with an alternative stop condition if we don't want the timeout. @tzulitai I'm a bit confused here, I know that we are trying to avoid timeouts as much as possible but in this particular case a timeout is still better than an infinite waiting loop in case of incorrect metrics. WDYT ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
