Gerrrr commented on code in PR #22:
URL:
https://github.com/apache/flink-connector-kafka/pull/22#discussion_r1159122981
##########
flink-connector-kafka/src/main/java/org/apache/flink/streaming/connectors/kafka/table/KafkaConnectorOptionsUtil.java:
##########
@@ -145,7 +145,7 @@ public static void validateSinkTopic(ReadableConfig
tableOptions) {
}
}
- private static void validateScanStartupMode(ReadableConfig tableOptions) {
Review Comment:
nit: we can keep this `private` as this PR does not add the scan startup
mode to upsert kafka.
##########
flink-connector-kafka/src/main/java/org/apache/flink/streaming/connectors/kafka/table/KafkaConnectorOptionsUtil.java:
##########
@@ -189,7 +189,7 @@ private static void validateScanStartupMode(ReadableConfig
tableOptions) {
});
}
- private static void validateScanBoundedMode(ReadableConfig tableOptions) {
Review Comment:
nit: package-private is probably sufficient here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
