dawidwys commented on code in PR #22:
URL:
https://github.com/apache/flink-connector-kafka/pull/22#discussion_r1159372779
##########
flink-connector-kafka/src/test/java/org/apache/flink/streaming/connectors/kafka/table/UpsertKafkaDynamicTableFactoryTest.java:
##########
@@ -390,6 +399,131 @@ private SerializationSchema<RowData>
createConfluentAvroSerSchema(
RowDataToAvroConverters.createConverter(rowType));
}
+ //
--------------------------------------------------------------------------------------------
+ // Bounded end-offset tests
+ //
--------------------------------------------------------------------------------------------
+
+ @Test
+ public void testBoundedSpecificOffsetsValidate() {
+ final Map<String, String> options = getFullSourceOptions();
+ options.put(
+ KafkaConnectorOptions.SCAN_BOUNDED_MODE.key(),
+ ScanBoundedMode.SPECIFIC_OFFSETS.toString());
+
+ assertThatThrownBy(() -> createTableSource(SOURCE_SCHEMA, options))
+ .isInstanceOf(ValidationException.class);
Review Comment:
could we assert the message as well to make sure the validation error is for
the expected reason.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
