gyfora commented on code in PR #565:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/565#discussion_r1170194258
##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/observer/SavepointObserver.java:
##########
@@ -142,6 +142,11 @@ void cleanupSavepointHistory(
SavepointInfo currentSavepointInfo,
Configuration observeConfig) {
+ if
(!configManager.getOperatorConfiguration().isSavepointCleanerEnabled()) {
+ LOG.info("Operator savepoint cleaner is not enabled, do not clean
savepointHistory");
+ return;
+ }
Review Comment:
I think we need to remove from the savepoint history / status even if the
cleanup is disabled otherwise the status will eventually grow too big and break
(size limit is 1 mb)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
