darenwkt commented on code in PR #565:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/565#discussion_r1183606414
##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/observer/SavepointObserver.java:
##########
@@ -142,6 +142,11 @@ void cleanupSavepointHistory(
SavepointInfo currentSavepointInfo,
Configuration observeConfig) {
+ if
(!configManager.getOperatorConfiguration().isSavepointCleanerEnabled()) {
+ LOG.info("Operator savepoint cleaner is not enabled, do not clean
savepointHistory");
+ return;
+ }
Review Comment:
Agreed, I have updated the logic to remove from savepoint history/status
even if cleanup is disabled. This ensures savepointHistory in CR is within
maxCount and maxAge. The only difference is cleanup disabled will not send
`disposeSavepoint` REST call to JM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
