XComp commented on code in PR #22422:
URL: https://github.com/apache/flink/pull/22422#discussion_r1172812148
##########
flink-runtime/src/test/java/org/apache/flink/runtime/leaderelection/TestingLeaderElectionEventHandler.java:
##########
@@ -74,6 +75,15 @@ private void ifRunning(Runnable action) {
}
}
+ @Override
+ public CompletableFuture<Void> onGrantLeadershipAsync(UUID
newLeaderSessionId) {
Review Comment:
I'm also not happy about having all the different testing implementations.
The two you mentioned have actually a purpose, though. They implement basic
functionality that would be annoying to implement for every test case using the
new `TestingGeneric*` implementations. Therefore, I would suggest leaving them
as is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
