XComp commented on code in PR #22422:
URL: https://github.com/apache/flink/pull/22422#discussion_r1173805207
##########
flink-runtime/src/main/java/org/apache/flink/runtime/leaderelection/LeaderElectionEventHandler.java:
##########
@@ -39,12 +40,29 @@ public interface LeaderElectionEventHandler {
*/
void onGrantLeadership(UUID newLeaderSessionId);
+ /**
+ * Called by specific {@link LeaderElectionDriver} when the leadership is
granted.
+ *
+ * <p>This method will trigger the grant event processing in a separate
thread.
+ *
+ * @param newLeaderSessionId the valid leader session id
+ */
+ CompletableFuture<Void> onGrantLeadershipAsync(UUID newLeaderSessionId);
Review Comment:
In the long run, we could remove the async calls again from the interface.
The driver implementations only need the synchronous methods only because their
event handling lives in a separate thread already. The asynchronous execution
would become an implementation detail of `DefaultLeaderElectionService`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
