zentol commented on code in PR #22422:
URL: https://github.com/apache/flink/pull/22422#discussion_r1173821559


##########
flink-runtime/src/main/java/org/apache/flink/runtime/leaderelection/LeaderElectionEventHandler.java:
##########
@@ -39,12 +40,29 @@ public interface LeaderElectionEventHandler {
      */
     void onGrantLeadership(UUID newLeaderSessionId);
 
+    /**
+     * Called by specific {@link LeaderElectionDriver} when the leadership is 
granted.
+     *
+     * <p>This method will trigger the grant event processing in a separate 
thread.
+     *
+     * @param newLeaderSessionId the valid leader session id
+     */
+    CompletableFuture<Void> onGrantLeadershipAsync(UUID newLeaderSessionId);

Review Comment:
   Why can't it be an implementation detail of the 
`DefaultLeaderElectionService` _now_?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to