reswqa commented on code in PR #22495:
URL: https://github.com/apache/flink/pull/22495#discussion_r1179915692
##########
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/DeclarativeSlotPoolService.java:
##########
@@ -134,7 +139,25 @@ public final void start(
*
* @param componentMainThreadExecutor componentMainThreadExecutor used by
this slot pool service
*/
- protected void onStart(ComponentMainThreadExecutor
componentMainThreadExecutor) {}
+ protected void onStart(ComponentMainThreadExecutor
componentMainThreadExecutor) {
Review Comment:
This check logic already exists in its subclass(i.e.
`DeclarativeSlotPoolBridge`), we'd better make some changes to the subclass to
reduce duplication of code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
