[GitHub] [flink] Samrat002 commented on a diff in pull request #22495: [FLINK-31080][Flink-runtime]Idle slots are not released due to a mismatch in time between DeclarativeSlotPoolService and SlotSharingSlotAllocator

Thu, 27 Apr 2023 23:14:45 -0700 


Samrat002 commented on code in PR #22495:
URL: https://github.com/apache/flink/pull/22495#discussion_r1179966813


##########
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/DeclarativeSlotPoolService.java:
##########
@@ -134,7 +139,25 @@ public final void start(
      *
      * @param componentMainThreadExecutor componentMainThreadExecutor used by 
this slot pool service
      */
-    protected void onStart(ComponentMainThreadExecutor 
componentMainThreadExecutor) {}
+    protected void onStart(ComponentMainThreadExecutor 
componentMainThreadExecutor) {
+        this.componentMainThreadExecutor = componentMainThreadExecutor;
+
+        componentMainThreadExecutor.schedule(
+                this::checkIdleSlotTimeout,
+                idleSlotTimeout.toMilliseconds(),
+                TimeUnit.MILLISECONDS);

Review Comment:
   <img width="1414" alt="Screenshot 2023-04-28 at 11 39 33 AM" 
src="https://user-images.githubusercontent.com/40290566/235068090-96b56fa8-ac5c-4d48-91e0-96cf4c52d269.png";>
   
   I am trying to open  
[FLINK-32399](https://issues.apache.org/jira/browse/FLINK-32399) and understand 
the change but unfortunately not able to view anything. Is this issue removed 
or need permission ?
   
   @reswqa can you help here please 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to