XComp commented on code in PR #21736:
URL: https://github.com/apache/flink/pull/21736#discussion_r1183429793
##########
flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaProducerMigrationOperatorTest.java:
##########
@@ -20,15 +20,14 @@
import org.apache.flink.FlinkVersion;
-import org.junit.Ignore;
import org.junit.runners.Parameterized;
import java.util.Arrays;
import java.util.Collection;
/**
* Migration test from FlinkKafkaProducer011 operator. This test depends on
the resource generated
- * by {@link FlinkKafkaProducer011MigrationTest#writeSnapshot()}.
+ * by {@link
FlinkKafkaProducerMigrationOperatorTest#writeSnapshot(FlinkVersion)}.
Review Comment:
Shouldn't we rather remove this test class (in a separate commit) as part of
this change? It looks like we're not benefiting from it anymore because it
checks old versions. Or am I missing something here? :thinking:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
