XComp commented on code in PR #21736:
URL: https://github.com/apache/flink/pull/21736#discussion_r1183451608
##########
flink-tests/src/test/java/org/apache/flink/test/state/operator/restore/AbstractOperatorRestoreTestBase.java:
##########
@@ -71,7 +80,17 @@
* AbstractOperatorRestoreTestBase#migrateJob}, please create the
corresponding test resource
* directory and copy the _metadata file by hand.
*/
-public abstract class AbstractOperatorRestoreTestBase extends TestLogger {
+public abstract class AbstractOperatorRestoreTestBase extends TestLogger
implements MigrationTest {
+
+ private static final FlinkVersion MIGRATION_BASE_VERSION =
FlinkVersion.v1_16;
Review Comment:
I feel like we need more documentation here, i.e. in-code comments. What
about not using a dedicated final field here. We're using it in one place only,
anyway. Additionally, can't we use 1.8 to make it clearer that the version
doesn't matter?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
