[
https://issues.apache.org/jira/browse/FLINK-4773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15595058#comment-15595058
]
ASF GitHub Bot commented on FLINK-4773:
---------------------------------------
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/2614
I think this is a good refactoring.
+1 to merge.
> Introduce an OperatorIOMetricGroup
> ----------------------------------
>
> Key: FLINK-4773
> URL: https://issues.apache.org/jira/browse/FLINK-4773
> Project: Flink
> Issue Type: Improvement
> Components: Metrics
> Affects Versions: 1.1.2
> Reporter: Chesnay Schepler
> Assignee: Chesnay Schepler
> Fix For: 1.2.0
>
>
> Task related IO metrics (numBytesIn/Out) are not instantiated directly by the
> task, but instead within the IOMetricGroup contained in the respective
> TaskMetricGroup. They are then later accessed by relevant components, instead
> of creating them themselves. This has the advantage that they can be accessed
> from several places, and that they are guaranteed to always be instantiated
> identically (without requiring static name constants).
> I propose to do the same for operators.
> This is also a prerequisite for FLINK-4733.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
