[
https://issues.apache.org/jira/browse/FLINK-4773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15559407#comment-15559407
]
ASF GitHub Bot commented on FLINK-4773:
---------------------------------------
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/2614
[FLINK-4773] Intoduce OperatorIOMetricGroup
This PR introduces the OperatorIOMetricGroup, which encapsulates the
insantiation of numRecordsIn/Out counters. For clarity purposes the
IOMetricGroup class was renamed to TaskIOMetricGroup.
The underlying reasoning for this change is the reuse of specific operator
counters for the task (first operator numRecordsIn == task recordsIn). With
this class we can more easily do this within the metric system.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zentol/flink 4773_metrics_opio
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/2614.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2614
----
commit 5f0f3598fa5d0fdf8b61d591e2bb94b74924ee0d
Author: zentol <ches...@apache.org>
Date: 2016-10-07T11:02:10Z
[FLINK-4773] [metrics] [refactor] Rename IOMetricGroup to TaskIOMetricGroup
commit df40a58c74e7f0fc3feec4a5848f1627bf4537dd
Author: zentol <ches...@apache.org>
Date: 2016-10-05T13:04:03Z
[FLINK-4773] [metrics] [refactor] Introduce OperatorIOMetricGroup
----
> Introduce an OperatorIOMetricGroup
> ----------------------------------
>
> Key: FLINK-4773
> URL: https://issues.apache.org/jira/browse/FLINK-4773
> Project: Flink
> Issue Type: Improvement
> Components: Metrics
> Affects Versions: 1.1.2
> Reporter: Chesnay Schepler
> Assignee: Chesnay Schepler
> Fix For: 1.2.0
>
>
> Task related IO metrics (numBytesIn/Out) are not instantiated directly by the
> task, but instead within the IOMetricGroup contained in the respective
> TaskMetricGroup. They are then later accessed by relevant components, instead
> of creating them themselves. This has the advantage that they can be accessed
> from several places, and that they are guaranteed to always be instantiated
> identically (without requiring static name constants).
> I propose to do the same for operators.
> This is also a prerequisite for FLINK-4733.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
