reswqa commented on code in PR #45:
URL: 
https://github.com/apache/flink-connector-jdbc/pull/45#discussion_r1184966872


##########
docs/data/jdbc.yml:
##########
@@ -18,4 +18,4 @@
 
 variants:
   - maven: flink-connector-jdbc
-    sql_url: 
https://repo.maven.apache.org/maven2/org/apache/flink/flink-sql-connector-jdbc/$full_version/flink-sql-connector-jdbc-$full_version.jar
+    sql_url: 
https://repo.maven.apache.org/maven2/org/apache/flink/flink-connector-jdbc/$full_version/flink-connector-jdbc-$full_version.jar

Review Comment:
   IIRC, `v3.1.0` should not have been released yet. So, I guess you mean that 
the jdbc connector supports `flink-1.17` will be the version `v3.1.0`.
   
   At present, the `release-1.17` branch of flink tracks the `v3.0` branch of 
the `flink-connnector-jdbc` repository. 
   
https://github.com/apache/flink-connector-jdbc/blob/b07bddfc8d741e203d3d9b6eeefe5113ecfb4acc/docs/content/docs/connectors/table/jdbc.md?plain=1#L41
   This line in `v3.0` branch indicates that the connector version is `v3.0.0`, 
which will cause `$full_version` to be replaced with `3.0.0-1,17`. If we want 
to release `v3.1.0`, modifying the version number here should be a necessary 
part of the release process.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to