reswqa commented on code in PR #45: URL: https://github.com/apache/flink-connector-jdbc/pull/45#discussion_r1185677895
########## docs/data/jdbc.yml: ########## @@ -18,4 +18,4 @@ variants: - maven: flink-connector-jdbc - sql_url: https://repo.maven.apache.org/maven2/org/apache/flink/flink-sql-connector-jdbc/$full_version/flink-sql-connector-jdbc-$full_version.jar + sql_url: https://repo.maven.apache.org/maven2/org/apache/flink/flink-connector-jdbc/$full_version/flink-connector-jdbc-$full_version.jar Review Comment: If `3.1.0` is the only version that support `flink-1.17`, there are two possibilities when releasing: - Create `v3.1` branch: let the `setup_docs.sh` tracks this branch. - Do not create `v3.1` branch: modify the doc in `jdbc-connector` repository, let `sql_connector_download_table "jdbc"` point to `3.1.0`. Both of these will automatically change the download url linked to `3.1.0-1.17`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
