mxm commented on code in PR #22556:
URL: https://github.com/apache/flink/pull/22556#discussion_r1189971406
##########
flink-table/flink-sql-client/src/test/java/org/apache/flink/table/client/SqlClientTest.java:
##########
@@ -156,6 +156,23 @@ void testGatewayMode() throws Exception {
assertThat(actual).contains("execution.target", "yarn-session");
}
+ @Test
+ void testGatewayModeUrl() throws Exception {
+ String[] args =
+ new String[] {
+ "gateway",
+ "-e",
+ new URL(
+ "http",
+
SQL_GATEWAY_REST_ENDPOINT_EXTENSION.getTargetAddress(),
+
SQL_GATEWAY_REST_ENDPOINT_EXTENSION.getTargetPort(),
+ "")
+ .toString()
+ };
+ String actual = runSqlClient(args, String.join("\n", "SET;", "QUIT;"),
false);
+ assertThat(actual).contains("execution.target", "yarn-session");
Review Comment:
Does this verify that the SQL client comes up? Kind of odd to have the
yarn-session in there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
