clownxc commented on PR #22555: URL: https://github.com/apache/flink/pull/22555#issuecomment-1542368896
> @clownxc Thanks for creating this pr! I'm curious why you don't fallback the value of globalDefaultSourceParallelism to parallelism.default if necessary outside the constructor of DefaultVertexParallelismAndInputInfosDecider? This change will be much cleaner. In addition, we do not require that parallelism.default must be a positive number. On the contrary, before version 1.17, users need to configure parallelism.default = -1 to enable parallelism derivation. WDYT? Thank you, I will try to modify the code as you say -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
