clownxc commented on code in PR #22555:
URL: https://github.com/apache/flink/pull/22555#discussion_r1190126807


##########
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptivebatch/DefaultVertexParallelismAndInputInfosDecider.java:
##########
@@ -546,7 +553,7 @@ static DefaultVertexParallelismAndInputInfosDecider from(
                 configuration.get(
                         
BatchExecutionOptions.ADAPTIVE_AUTO_PARALLELISM_AVG_DATA_VOLUME_PER_TASK),
                 configuration.get(
-                        BatchExecutionOptions
-                                
.ADAPTIVE_AUTO_PARALLELISM_DEFAULT_SOURCE_PARALLELISM));
+                        
BatchExecutionOptions.ADAPTIVE_AUTO_PARALLELISM_DEFAULT_SOURCE_PARALLELISM),
+                configuration.get(CoreOptions.DEFAULT_PARALLELISM));
     }

Review Comment:
   > parallelism.default should be obtained from ExecutionConfig instead of 
jobmaster Configuration
   
   The value of `ExecutionConfig#PARALLELISM_DEFAULT` is always `-1`
   ```java
       public static final int PARALLELISM_DEFAULT = -1;
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to