snuyanzin commented on code in PR #22579:
URL: https://github.com/apache/flink/pull/22579#discussion_r1195224921
##########
flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/runtime/batch/sql/join/LookupJoinITCase.scala:
##########
@@ -301,28 +374,46 @@ class LookupJoinITCase(legacyTableSource: Boolean,
isAsyncMode: Boolean, cacheTy
BatchTestBase.row(null, 11, null),
BatchTestBase.row(null, 12, null))
checkResult(sql, expected)
+ afterEach(legacyTableSource)
}
- @Test
- def testJoinTemporalTableOnNullConstantKey(): Unit = {
+ @ParameterizedTest
+ @MethodSource(Array("parameters"))
+ def testJoinTemporalTableOnNullConstantKey(
+ legacyTableSource: Boolean,
+ isAsyncMode: Boolean,
+ cacheType: LookupCacheType): Unit = {
+ beforeEach(legacyTableSource, isAsyncMode, cacheType);
val sql = s"SELECT T.id, T.len, T.content FROM T JOIN userTable " +
"for system_time as of T.proctime AS D ON D.id = null"
val expected = Seq()
checkResult(sql, expected)
+ afterEach(legacyTableSource)
}
- @Test
- def testJoinTemporalTableOnMultiKeyFieldsWithNullConstantKey(): Unit = {
+ @ParameterizedTest
+ @MethodSource(Array("parameters"))
+ def testJoinTemporalTableOnMultiKeyFieldsWithNullConstantKey(
+ legacyTableSource: Boolean,
+ isAsyncMode: Boolean,
+ cacheType: LookupCacheType): Unit = {
+ beforeEach(legacyTableSource, isAsyncMode, cacheType);
val sql = s"SELECT T.id, T.len, D.name FROM T JOIN userTable " +
"for system_time as of T.proctime AS D ON T.content = D.name AND null =
D.id"
val expected = Seq()
checkResult(sql, expected)
+ afterEach(legacyTableSource)
}
- @Test
- def testJoinTemporalTableWithComputedColumn(): Unit = {
+ @ParameterizedTest
+ @MethodSource(Array("parameters"))
+ def testJoinTemporalTableWithComputedColumn(
+ legacyTableSource: Boolean,
+ isAsyncMode: Boolean,
+ cacheType: LookupCacheType): Unit = {
+ beforeEach(legacyTableSource, isAsyncMode, cacheType);
// Computed column do not support in legacyTableSource.
- Assume.assumeFalse(legacyTableSource)
+ assertThat(legacyTableSource).isFalse
Review Comment:
```suggestion
assumeThat(legacyTableSource).isFalse
```
since it is an assumption it should probably be `assumeThat`
##########
flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/runtime/batch/sql/join/LookupJoinITCase.scala:
##########
@@ -333,12 +424,18 @@ class LookupJoinITCase(legacyTableSource: Boolean,
isAsyncMode: Boolean, cacheTy
BatchTestBase.row(2, 15, "Hello", "Jark", 22, 23),
BatchTestBase.row(3, 15, "Fabian", "Fabian", 33, 34))
checkResult(sql, expected)
+ afterEach(legacyTableSource)
}
- @Test
- def testJoinTemporalTableWithComputedColumnAndPushDown(): Unit = {
+ @ParameterizedTest
+ @MethodSource(Array("parameters"))
+ def testJoinTemporalTableWithComputedColumnAndPushDown(
+ legacyTableSource: Boolean,
+ isAsyncMode: Boolean,
+ cacheType: LookupCacheType): Unit = {
+ beforeEach(legacyTableSource, isAsyncMode, cacheType);
// Computed column do not support in legacyTableSource.
- Assume.assumeFalse(legacyTableSource)
+ assertThat(legacyTableSource).isTrue
Review Comment:
```suggestion
assumeThat(legacyTableSource).isTrue
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
