reswqa commented on code in PR #22579:
URL: https://github.com/apache/flink/pull/22579#discussion_r1206475729
##########
flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/runtime/batch/sql/join/OuterJoinITCase.scala:
##########
@@ -398,7 +398,7 @@ class OuterJoinITCase(expectedJoinType: JoinType) extends
BatchTestBase {
}
object OuterJoinITCase {
- @Parameterized.Parameters(name = "{0}")
+ @Parameters(name = "{0}")
Review Comment:
```suggestion
@Parameters(name = "expectedJoinType={0}")
```
##########
flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/runtime/batch/sql/join/SemiJoinITCase.scala:
##########
@@ -470,7 +469,7 @@ class SemiJoinITCase(expectedJoinType: JoinType) extends
BatchTestBase {
}
object SemiJoinITCase {
- @Parameterized.Parameters(name = "{0}-{1}")
+ @Parameters(name = "{0}-{1}")
Review Comment:
It feels a bit strange, isn't this test class only one parameter?
##########
flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/runtime/batch/sql/join/LookupJoinITCase.scala:
##########
@@ -26,23 +26,31 @@ import
org.apache.flink.table.planner.factories.TestValuesTableFactory
import org.apache.flink.table.planner.runtime.utils.{BatchTestBase,
InMemoryLookupableTableSource}
import
org.apache.flink.table.runtime.functions.table.fullcache.inputformat.FullCacheTestInputFormat
import org.apache.flink.table.runtime.functions.table.lookup.LookupCacheManager
+import org.apache.flink.testutils.junit.extensions.parameterized.{Parameter,
ParameterizedTestExtension, Parameters}
import org.apache.flink.types.Row
import org.assertj.core.api.Assertions.assertThat
+import org.assertj.core.api.Assumptions.assumeThat
import org.assertj.core.api.IterableAssert.assertThatIterable
-import org.junit.{After, Assume, Before, Test}
-import org.junit.Assert.assertEquals
-import org.junit.runner.RunWith
-import org.junit.runners.Parameterized
+import org.junit.jupiter.api.{AfterEach, BeforeEach, TestTemplate}
+import org.junit.jupiter.api.Assertions.assertEquals
Review Comment:
Junit5 assertions are also discouraged.
##########
flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/runtime/batch/sql/join/JoinITCase.scala:
##########
@@ -1333,7 +1335,7 @@ class JoinITCase(expectedJoinType: JoinType) extends
BatchTestBase {
}
object JoinITCase {
- @Parameterized.Parameters(name = "{0}")
+ @Parameters(name = "{0}")
Review Comment:
```suggestion
@Parameters(name = "expectedJoinType = {0}")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
