TanYuxin-tyx commented on code in PR #22573:
URL: https://github.com/apache/flink/pull/22573#discussion_r1196042134
##########
flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/runtime/batch/sql/MultipleInputITCase.scala:
##########
@@ -74,13 +73,14 @@ class MultipleInputITCase(shuffleMode: BatchShuffleMode,
schedulerType: Schedule
MultipleInputITCase.rowType,
"a, b, c, nt",
MultipleInputITCase.nullables)
-
- tEnv.getConfig.set(ExecutionOptions.BATCH_SHUFFLE_MODE, shuffleMode)
- tEnv.getConfig.set(JobManagerOptions.SCHEDULER, schedulerType)
}
- @Test
- def testBasicMultipleInput(): Unit = {
+ @ParameterizedTest
+ @MethodSource(Array("parameters"))
Review Comment:
Fixed.
##########
flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/runtime/batch/sql/PartitionableSinkITCase.scala:
##########
@@ -31,41 +31,32 @@ import
org.apache.flink.table.descriptors.ConnectorDescriptorValidator.CONNECTOR
import org.apache.flink.table.descriptors.DescriptorProperties
import org.apache.flink.table.descriptors.Schema.SCHEMA
import org.apache.flink.table.factories.TableSinkFactory
-import
org.apache.flink.table.planner.runtime.batch.sql.PartitionableSinkITCase.{type4,
type_int_string, _}
+import
org.apache.flink.table.planner.runtime.batch.sql.PartitionableSinkITCase.{type4,
_}
import org.apache.flink.table.planner.runtime.utils.BatchTestBase
import org.apache.flink.table.planner.runtime.utils.BatchTestBase.row
import org.apache.flink.table.planner.runtime.utils.TestData._
import org.apache.flink.table.sinks.{PartitionableTableSink, StreamTableSink,
TableSink}
import org.apache.flink.table.types.logical.{BigIntType, IntType, VarCharType}
import org.apache.flink.table.types.utils.TypeConversions
-import org.apache.flink.table.utils.LegacyRowResource
-import org.apache.flink.types.Row
+import org.apache.flink.types.{Row, RowUtils}
-import org.junit.{Before, Rule, Test}
-import org.junit.Assert._
-import org.junit.rules.ExpectedException
+import org.assertj.core.api.Assertions.{assertThat, assertThatThrownBy}
+import org.assertj.core.api.IterableAssert.assertThatIterable
+import org.junit.jupiter.api.{AfterEach, BeforeEach, Test}
import java.util
import java.util.{function, ArrayList => JArrayList, LinkedList =>
JLinkedList, List => JList, Map => JMap}
import scala.collection.JavaConversions._
import scala.collection.JavaConverters._
-import scala.collection.Seq
/** Test cases for [[org.apache.flink.table.sinks.PartitionableTableSink]]. */
class PartitionableSinkITCase extends BatchTestBase {
- private val _expectedException = ExpectedException.none
-
- @Rule
- def expectedEx: ExpectedException = _expectedException
-
- @Rule
- def usesLegacyRows: LegacyRowResource = LegacyRowResource.INSTANCE
-
- @Before
+ @BeforeEach
override def before(): Unit = {
super.before()
+ RowUtils.USE_LEGACY_TO_STRING = true
Review Comment:
Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
