TanYuxin-tyx commented on code in PR #22573:
URL: https://github.com/apache/flink/pull/22573#discussion_r1196043569
##########
flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/runtime/batch/sql/PartitionableSinkITCase.scala:
##########
@@ -98,34 +97,33 @@ class PartitionableSinkITCase extends BatchTestBase {
"3,2,Hello02",
"3,2,Hello03",
"3,2,Hello04"
- ),
- RESULT3.sorted
- )
+ ))
}
@Test
def testInsertWithPartitionGrouping(): Unit = {
registerTableSink()
tEnv.executeSql("insert into sinkTable select a, b, c from
sortTable").await()
- assertEquals(List("1,1,Hello world", "1,1,Hello world, how are you?"),
RESULT1.toList)
- assertEquals(
- List("4,4,你好，陌生人", "4,4,你好，陌生人，我是", "4,4,你好，陌生人，我是中国人",
"4,4,你好，陌生人，我是中国人，你来自哪里？"),
- RESULT2.toList)
- assertEquals(
+ assertThatIterable(RESULT1).containsExactlyElementsOf(
Review Comment:
Because the type of RESULT1 and the `List` are different. Using
assertThatIterable is more appropriate.
##########
flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/runtime/batch/sql/PartitionableSourceITCase.scala:
##########
@@ -89,7 +88,6 @@ class PartitionableSourceITCase(val sourceFetchPartitions:
Boolean, val useCatal
| 'filterable-fields' = 'id;part1;part2'
|)
|""".stripMargin
-
Review Comment:
Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
