godfreyhe commented on code in PR #22593:
URL: https://github.com/apache/flink/pull/22593#discussion_r1198483617
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/stream/StreamExecJoin.java:
##########
@@ -119,12 +139,14 @@ public StreamExecJoin(
@JsonProperty(FIELD_NAME_RIGHT_UPSERT_KEYS) List<int[]>
rightUpsertKeys,
@JsonProperty(FIELD_NAME_INPUT_PROPERTIES) List<InputProperty>
inputProperties,
@JsonProperty(FIELD_NAME_OUTPUT_TYPE) RowType outputType,
- @JsonProperty(FIELD_NAME_DESCRIPTION) String description) {
+ @JsonProperty(FIELD_NAME_DESCRIPTION) String description,
+ @Nullable @JsonProperty(FIELD_NAME_STATE) List<StateMetadata>
stateMetadataList) {
Review Comment:
nit: the `inputProperties` , `outputType `, `description ` are common
attribute in each ExecNode, and they are placed in the last position by default.
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/stream/StreamExecChangelogNormalize.java:
##########
@@ -71,20 +75,36 @@
producedTransformations =
StreamExecChangelogNormalize.CHANGELOG_NORMALIZE_TRANSFORMATION,
minPlanVersion = FlinkVersion.v1_15,
minStateVersion = FlinkVersion.v1_15)
+@ExecNodeMetadata(
+ name = "stream-exec-changelog-normalize",
+ version = 2,
Review Comment:
Do we really need to introduce a new version ? Because the topology and
state layout do not change,
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
