LadyForest commented on code in PR #22593:
URL: https://github.com/apache/flink/pull/22593#discussion_r1215355425
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/common/CommonExecLookupJoin.java:
##########
@@ -332,7 +319,7 @@ protected Transformation<RowData> createJoinTransformation(
}
}
- private Transformation<RowData> createSyncLookupJoinWithState(
+ protected Transformation<RowData> createSyncLookupJoinWithState(
Review Comment:
Because only `StreamExecLookupJoin` needs stateful lookup join under certain
circumstances. But `CommonExecLookupJoin#createJoinTransformation` is shared by
both `BatchExecLookupJoin` and `StreamExecLookupJoin`.
WDYT if we make the `createSyncLookupJoinWithState ` abstract and let
subclasses override?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
