reswqa commented on code in PR #22616: URL: https://github.com/apache/flink/pull/22616#discussion_r1200450707
########## flink-runtime/src/test/java/org/apache/flink/runtime/io/disk/iomanager/AsynchronousFileIOChannelTest.java: ########## @@ -47,7 +45,6 @@ import static org.junit.Assert.fail; import static org.mockito.Mockito.mock; Review Comment: My idea is that the tests in the `AsynchronousFileIOChannelTest` class should not care about the specific implementation of the buffer, so we can simply construct a real buffer instead of mocking it(maybe via `BufferBuilderTestUtils.buildSomeBuffer();`). But, It's fair enough not to make this change as we have extensively used mocks in the `runtime` module and cannot completely remove them at this time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
