snuyanzin commented on code in PR #22632:
URL: https://github.com/apache/flink/pull/22632#discussion_r1204282054
##########
flink-runtime/src/test/java/org/apache/flink/runtime/state/TaskExecutorLocalStateStoresManagerTest.java:
##########
@@ -221,44 +231,43 @@ public void
testSubtaskStateStoreDirectoryCreateAndDelete() throws Exception {
.orElseThrow(LocalRecoveryConfig.localRecoveryNotEnabled());
for (int i = 0; i < 10; ++i) {
- Assert.assertEquals(
- new File(
- rootDirs[(i & Integer.MAX_VALUE) %
rootDirs.length],
-
storesManager.allocationSubDirString(allocationID)),
- directoryProvider.allocationBaseDirectory(i));
+ assertThat(
+ new File(
+ rootDirs[(i & Integer.MAX_VALUE) %
rootDirs.length],
+
storesManager.allocationSubDirString(allocationID)))
+ .isEqualTo(directoryProvider.allocationBaseDirectory(i));
}
long chkId = 42L;
File allocBaseDirChk42 =
directoryProvider.allocationBaseDirectory(chkId);
File subtaskSpecificCheckpointDirectory =
directoryProvider.subtaskSpecificCheckpointDirectory(chkId);
- Assert.assertEquals(
- new File(
- allocBaseDirChk42,
- "jid_"
- + jobID
- + File.separator
- + "vtx_"
- + jobVertexID
- + "_"
- + "sti_"
- + subtaskIdx
- + File.separator
- + "chk_"
- + chkId),
- subtaskSpecificCheckpointDirectory);
-
- Assert.assertTrue(subtaskSpecificCheckpointDirectory.mkdirs());
+ assertThat(
+ new File(
+ allocBaseDirChk42,
+ "jid_"
+ + jobID
+ + File.separator
+ + "vtx_"
+ + jobVertexID
+ + "_"
+ + "sti_"
+ + subtaskIdx
+ + File.separator
+ + "chk_"
+ + chkId))
+ .isEqualTo(subtaskSpecificCheckpointDirectory);
+
+ assertThat(subtaskSpecificCheckpointDirectory.mkdirs()).isTrue();
File testFile = new File(subtaskSpecificCheckpointDirectory, "test");
- Assert.assertTrue(testFile.createNewFile());
+ assertThat(testFile.createNewFile()).isTrue();
// test that local recovery mode is forwarded to the created store
- Assert.assertEquals(
- storesManager.isLocalRecoveryEnabled(),
-
taskLocalStateStore.getLocalRecoveryConfig().isLocalRecoveryEnabled());
+
assertThat(taskLocalStateStore.getLocalRecoveryConfig().isLocalRecoveryEnabled())
+ .isEqualTo(storesManager.isLocalRecoveryEnabled());
- Assert.assertTrue(testFile.exists());
+ assertThat(testFile.exists()).isTrue();
Review Comment:
```suggestion
assertThat(testFile).exists();
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
