snuyanzin commented on code in PR #22632:
URL: https://github.com/apache/flink/pull/22632#discussion_r1204237860
##########
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/netty/NettyLeakDetectionExtension.java:
##########
@@ -85,7 +87,7 @@ protected synchronized void after() {
private static class FailingResourceLeakDetectorFactory extends
ResourceLeakDetectorFactory {
public <T> ResourceLeakDetector<T> newResourceLeakDetector(
Class<T> resource, int samplingInterval, long maxActive) {
- return new FailingResourceLeakDetector<T>(resource,
samplingInterval, maxActive);
+ return new FailingResourceLeakDetector<>(resource,
samplingInterval, maxActive);
Review Comment:
```suggestion
return new FailingResourceLeakDetector<>(resource,
samplingInterval);
```
and below use
```java
FailingResourceLeakDetector(Class<?> resourceType, int samplingInterval) {
super(resourceType, samplingInterval);
}
```
since
`org.apache.flink.shaded.netty4.io.netty.util.ResourceLeakDetector#ResourceLeakDetector(java.lang.Class<?>,
int, long)` is deprecated in favor of
`org.apache.flink.shaded.netty4.io.netty.util.ResourceLeakDetector#ResourceLeakDetector(java.lang.Class<?>,
int)`
at
https://github.com/netty/netty/commit/14b902fced27440c499bc2500d2410a6bab99805
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
