XComp opened a new pull request, #22656:
URL: https://github.com/apache/flink/pull/22656

   ## What is the purpose of the change
   
   The error handling needs to be moved into the driver to allow errors that 
were reported to the 
   k8s watcher to be forwarded to the `LeaderContender`'s error handling. This 
aligns with how the `LeaderElectionDriver` was used.
   
   This step is necessary so that we can replace the `LeaderElectionDriver` 
within `DefaultLeaderElectionService` with the 
`MultipleComponentLeaderElectionDriver`.
   
   ## Brief change log
   
   * Makes the `fatalErrorHandler` being a parameter of 
`MultipleComponentLeaderElectionDriverFactory.create`
   * Moves `fatalErrorHandler` from 
`DefaultMultipleComponentLeaderElectionService` into the 
`MultipleComponentLeaderElectionDriver` implementations
   
   ## Verifying this change
   
   * added a test in `handleFatalError` in 
`DefaultMultipleComponentLeaderElectionService`
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: yes
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? not applicable


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to