[ 
https://issues.apache.org/jira/browse/FLINK-3702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15603088#comment-15603088
 ] 

ASF GitHub Bot commented on FLINK-3702:
---------------------------------------

Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2094#discussion_r84767676
  
    --- Diff: 
flink-core/src/main/java/org/apache/flink/api/java/typeutils/TupleTypeInfoBase.java
 ---
    @@ -203,7 +206,34 @@ public void getFlatFields(String fieldExpression, int 
offset, List<FlatFieldDesc
                TypeInformation<X> typed = (TypeInformation<X>) this.types[pos];
                return typed;
        }
    -   
    +
    +   @Override
    +   @PublicEvolving
    +   public <F> FieldAccessor<T, F> getFieldAccessor(int pos, 
ExecutionConfig config) {
    +           return new FieldAccessor.SimpleTupleFieldAccessor<T, F>(pos, 
this);
    +   }
    +
    +   @Override
    +   @PublicEvolving
    +   public <F> FieldAccessor<T, F> getFieldAccessor(String fieldExpression, 
ExecutionConfig config) {
    +           FieldAccessor.FieldExpression decomp = 
FieldAccessor.decomposeFieldExpression(fieldExpression);
    +           int fieldPos = this.getFieldIndex(decomp.head);
    +           if (fieldPos == -1) {
    +                   try {
    +                           fieldPos = Integer.parseInt(decomp.head);
    +                   } catch (NumberFormatException ex) {
    +                           throw new InvalidFieldReferenceException("Tried 
to select field \"" + decomp.head
    --- End diff --
    
    Exception does not tell user that only integer values are allowed.


> DataStream API PojoFieldAccessor doesn't support nested POJOs
> -------------------------------------------------------------
>
>                 Key: FLINK-3702
>                 URL: https://issues.apache.org/jira/browse/FLINK-3702
>             Project: Flink
>          Issue Type: Improvement
>          Components: DataStream API
>    Affects Versions: 1.0.0
>            Reporter: Robert Metzger
>            Assignee: Gabor Gevay
>
> The {{PojoFieldAccessor}} (which is used by {{.sum(String)}} and similar 
> methods) doesn't support nested POJOs right now.
> As part of FLINK-3697 I'll add a check for a nested POJO and fail with an 
> exception.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to